Fix: if field has custom decoder, schema takes it into account #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from original to update fokr
Pull from master repository
Pull from main repo
… as it will be replaced by it
|
This is just an initial version. I'd like to know if I'm in the right direction or if this isn't it. |
|
@george-zubrienko I reverted all formatting changes except for a single line which only contained spaces which PyCharm just won't let me change back, I hope it's not a deal breaker. |
george-zubrienko
approved these changes
Aug 7, 2023
deansg
added a commit
to deansg/dataclasses-json
that referenced
this pull request
Aug 9, 2023
Fix: if field has custom decoder, schema takes it into account (lidatong#462)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a field has a custom decoder, replace its _deserialize logic with a dummy method, as it will be taken care of by the decoder.
Attempts to solve #460